Fix sed delimiter conflict with Windows-style paths in install-wp-tests.sh#383
Merged
swissspidy merged 3 commits intomainfrom Apr 14, 2026
Merged
Conversation
2 tasks
github-actions
bot
added
bug
command:scaffold-plugin-tests
Agent-Logs-Url: https://github.com/wp-cli/scaffold-command/sessions/31d688c6-5662-4889-b974-5efd14c88b58 Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix
Fix sed delimiter conflict with Windows-style paths in install-wp-tests.sh
Apr 14, 2026
sed command failure with Windows paths
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes install-wp-tests.sh failing when WP_CORE_DIR is provided as a Windows drive path (e.g., C:/...) by avoiding : as the sed substitution delimiter.
Changes:
- Switch the two
sedsubstitutions that inject$WP_CORE_DIRintowp-tests-config.phpfrom:to|delimiters to prevent delimiter conflicts with Windows drive letters.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/wp-cli/scaffold-command/sessions/37c08c59-4336-445f-a97f-9a230674efb6 Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seddelimiter conflict with Windows paths ininstall-wp-tests.sh(lines 231-232: change:delimiter to|)sedreplacement characters (\,|,&) in$WP_CORE_DIRbefore use in substitution