Conversation
current on by default, but may change that
to avoid selecting divs we don't mean to
mainly so it looks better in dark mode but keep the odd/even background thing for now (note Furo's table style doesn't do this)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 15 15
Lines 1785 1786 +1
=======================================
+ Hits 1684 1685 +1
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates styling and responsiveness behavior for the abcjs Jupyter widget, and restores/improves documentation CSS for pandas dataframe rendering and ipywidgets dark-mode compatibility.
Changes:
- Add a
responsivewidget option wired through Python traitlets → JS render options, with CSS-variable-driven max-width behavior. - Rename the widget root CSS class to a less generic name and adjust overflow behavior to support horizontal scrolling.
- Add/restore docs CSS for pandas tables and apply Furo-compatible overrides for embedded ipywidgets (including noUiSlider).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyabc2/abcjs/widget/index.js |
Adds responsive mode handling and clears lingering inline styles across re-renders. |
pyabc2/abcjs/widget/index.css |
Switches to abcjs-widget-container root class and adjusts overflow/max-width behavior. |
pyabc2/abcjs/widget/__init__.py |
Introduces responsive traitlet and exposes it in the interactive() control panel. |
docs/_static/custom.css |
Restores pandas table styling and adds Furo-compatible dark-mode overrides for ipywidgets UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly for abcjs. Also restored (and improved) pandas df styling and added styling for ipywidgets in docs nbs to work with Furo's dark mode.