Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 94.40% 94.54% +0.14%
==========================================
Files 15 16 +1
Lines 1786 1833 +47
==========================================
+ Hits 1686 1733 +47
Misses 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new pyabc2.sources.hardy source module for loading Paul Hardy tunebooks, with accompanying tests and documentation updates to surface the new source in the public docs/examples.
Changes:
- Introduce
pyabc2.sources.hardywith download + cachedload_meta()for Hardy tunebooks. - Add test coverage for Hardy source loading and key validation.
- Update documentation (API reference, changelog, and examples notebook) to include Hardy.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_sources.py |
Adds tests for hardy.load_meta() behavior, bad-key handling, and a URL currency check for the annex tunebook. |
pyabc2/sources/hardy.py |
New source module implementing download + cached loading and tune-block splitting with optional prefix stripping. |
docs/examples/sources.ipynb |
Demonstrates using the new Hardy source in the examples notebook. |
docs/changes.md |
Notes the new Hardy source in the changelog. |
docs/api.rst |
Adds Hardy module/functions to the generated API docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.