[O2B-1552] Move ad hoc filters inside runs overviews model to filtering model#2106
Open
NarrowsProjects wants to merge 87 commits intomainfrom
Open
Conversation
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page * lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes --------- Co-authored-by: GuustMetz <guust.metz@cern.ch> Co-authored-by: Guust <metzguust@gmail.com>
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
added 11 commits
April 15, 2026 08:46
NarrowsProjects
changed the title
4 tasks
Base automatically changed from
improv/O2B-1547/Migrate-LhcPeriodOverviewModel-to-use-FilteringModel-pattern
to
main
April 17, 2026 13:31
…unsOverviewModel-to-filteringModel
…unsOverviewModel-to-filteringModel
…cNotBadFraction name
…unsOverviewModel-to-filteringModel
…y to only notify when notBadFraction is not empty.
isaachilly
reviewed
Apr 20, 2026
| * | ||
| * @return {boolean} true if filter is stable beams only | ||
| */ | ||
| isToggled() { |
Collaborator
There was a problem hiding this comment.
Could this be a getter? isToggled represents a state rather than an action, so I think it would be more natural, what do you think?
Collaborator
Author
There was a problem hiding this comment.
It makes sense, especially since there is already precedence for this with how FilterModels have isEmpty as a getter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Filter restructuring
ddflpFilter,dcsFilter, andepnFilterhave been moved to thefilteringModel.detectorsQc[_id][notBadFraction]filters have been moved to a new model:MultiCompositeFilterModel.gaq[notBadFraction]now uses its own filter model with unique normalization logic:GaqFilterModel.New filter models
GaqFilterModelgaq[notBadFraction].ToggleFilterModelmcReproducibleAsNotBadhas been converted to use this model.MultiCompositeFilterModelShared filter behavior
mcReproducibleAsNotBad:ToggleFilterModel.GaqFilterModelMultiCompositeFilterModelNew components
RadioButtonFilterToggleFilter(component + model)ToggleFilterModel.Renaming
detectorsQc[_id][notBadFraction]→detectorsQcNotBadFraction[_id]filterModel.Implementation note
This approach avoids:
NumericalComparisonFilterModelsolely for normalization, orMultiCompositeFilterModelwithin anotherMultiCompositeFilterModelto achieve automatic normalization.Changes made to the database: