Skip to content

[O2B-1552] Move ad hoc filters inside runs overviews model to filtering model #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NarrowsProjects wants to merge 87 commits into
base: main
Choose a base branch
from

feat: change isToggled to a getter

4e215a4
Select commit
Loading
Failed to load commit list.
Open

[O2B-1552] Move ad hoc filters inside runs overviews model to filtering model #2106

feat: change isToggled to a getter
4e215a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 20, 2026 in 0s

45.99% (+0.12%) compared to 9e26f06

View this Pull Request on Codecov

45.99% (+0.12%) compared to 9e26f06

Details

Codecov Report

❌ Patch coverage is 7.07071% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.99%. Comparing base (9e26f06) to head (4e215a4).

Files with missing lines Patch % Lines
.../Filters/RunsFilter/MultiCompositionFilterModel.js 0.00% 23 Missing ⚠️
...ic/components/Filters/RunsFilter/GaqFilterModel.js 0.00% 22 Missing ⚠️
...onents/Filters/common/filters/ToggleFilterModel.js 0.00% 11 Missing ⚠️
...onents/Filters/common/filters/radioButtonFilter.js 0.00% 8 Missing ⚠️
.../components/Filters/common/filters/toggleFilter.js 0.00% 6 Missing ⚠️
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 6 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 4 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 3 Missing ⚠️
...omponents/Filters/common/RadioButtonFilterModel.js 0.00% 2 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
+ Coverage   45.86%   45.99%   +0.12%     
==========================================
  Files        1038     1037       -1     
  Lines       17173    17129      -44     
  Branches     3115     3108       -7     
==========================================
+ Hits         7877     7878       +1     
+ Misses       9296     9251      -45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov