Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds missing PowerShell adapter resource JSON files to the build/package manifest so they are included in produced artifacts.
Changes:
- Include
PowerShell_adapter.dsc.resource.jsonin multiple PowerShell-related package lists. - Include
WindowsPowerShell_adapter.dsc.resource.jsonin the Windows PowerShell-related package list.
| "powershell.dsc.extension.json", | ||
| "powershell.discover.ps1", | ||
| "powershell.dsc.resource.json", | ||
| "PowerShell_adapter.dsc.resource.json", |
There was a problem hiding this comment.
The newly added filenames use different casing/formatting than surrounding entries (which are largely lowercase). If the packaging/build runs on a case-sensitive filesystem (common in Linux CI or container builds), any mismatch between these strings and the actual on-disk filenames will cause file-not-found errors and missing artifacts. Recommendation: ensure these entries match the exact on-disk filenames and consider aligning naming/casing conventions with the rest of the manifest to reduce cross-platform packaging risk.
| "sshd-subsystem.dsc.resource.json", | ||
| "sshd-subsystemList.dsc.resource.json", | ||
| "windowspowershell.dsc.resource.json", | ||
| "WindowsPowerShell_adapter.dsc.resource.json", |
There was a problem hiding this comment.
The newly added filenames use different casing/formatting than surrounding entries (which are largely lowercase). If the packaging/build runs on a case-sensitive filesystem (common in Linux CI or container builds), any mismatch between these strings and the actual on-disk filenames will cause file-not-found errors and missing artifacts. Recommendation: ensure these entries match the exact on-disk filenames and consider aligning naming/casing conventions with the rest of the manifest to reduce cross-platform packaging risk.
| "WindowsPowerShell_adapter.dsc.resource.json", | |
| "windowspowershell_adapter.dsc.resource.json", |
| "powershell.dsc.extension.json", | ||
| "powershell.discover.ps1", | ||
| "powershell.dsc.resource.json", | ||
| "PowerShell_adapter.dsc.resource.json", |
There was a problem hiding this comment.
The same adapter filename is duplicated across multiple lists in this manifest, which increases the chance of future drift (added in one place but forgotten in others). If your build tooling supports it, consider centralizing these shared entries (e.g., via a shared include/template or generation step) so the adapter set is defined once and reused.
| "powershell.dsc.extension.json", | ||
| "powershell.discover.ps1", | ||
| "powershell.dsc.resource.json", | ||
| "PowerShell_adapter.dsc.resource.json", |
There was a problem hiding this comment.
The same adapter filename is duplicated across multiple lists in this manifest, which increases the chance of future drift (added in one place but forgotten in others). If your build tooling supports it, consider centralizing these shared entries (e.g., via a shared include/template or generation step) so the adapter set is defined once and reused.
| "powershell.dsc.extension.json", | ||
| "powershell.discover.ps1", | ||
| "powershell.dsc.resource.json", | ||
| "PowerShell_adapter.dsc.resource.json", |
There was a problem hiding this comment.
The same adapter filename is duplicated across multiple lists in this manifest, which increases the chance of future drift (added in one place but forgotten in others). If your build tooling supports it, consider centralizing these shared entries (e.g., via a shared include/template or generation step) so the adapter set is defined once and reused.
PR Summary
The new PS Adapters were missing from the package