Skip to content

Add newer PS Adapters to pkg #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveL-MSFT wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Add newer PS Adapters to pkg #1485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"powershell.dsc.extension.json",
"powershell.discover.ps1",
"powershell.dsc.resource.json",
"PowerShell_adapter.dsc.resource.json",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added filenames use different casing/formatting than surrounding entries (which are largely lowercase). If the packaging/build runs on a case-sensitive filesystem (common in Linux CI or container builds), any mismatch between these strings and the actual on-disk filenames will cause file-not-found errors and missing artifacts. Recommendation: ensure these entries match the exact on-disk filenames and consider aligning naming/casing conventions with the rest of the manifest to reduce cross-platform packaging risk.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same adapter filename is duplicated across multiple lists in this manifest, which increases the chance of future drift (added in one place but forgotten in others). If your build tooling supports it, consider centralizing these shared entries (e.g., via a shared include/template or generation step) so the adapter set is defined once and reused.

Copilot uses AI. Check for mistakes.
"psDscAdapter/",
"psscript.ps1",
"psscript.dsc.resource.json",
Expand Down Expand Up @@ -51,6 +52,7 @@
"powershell.dsc.extension.json",
"powershell.discover.ps1",
"powershell.dsc.resource.json",
"PowerShell_adapter.dsc.resource.json",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same adapter filename is duplicated across multiple lists in this manifest, which increases the chance of future drift (added in one place but forgotten in others). If your build tooling supports it, consider centralizing these shared entries (e.g., via a shared include/template or generation step) so the adapter set is defined once and reused.

Copilot uses AI. Check for mistakes.
"psDscAdapter/",
"psscript.ps1",
"psscript.dsc.resource.json",
Expand Down Expand Up @@ -83,6 +85,7 @@
"powershell.dsc.extension.json",
"powershell.discover.ps1",
"powershell.dsc.resource.json",
"PowerShell_adapter.dsc.resource.json",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same adapter filename is duplicated across multiple lists in this manifest, which increases the chance of future drift (added in one place but forgotten in others). If your build tooling supports it, consider centralizing these shared entries (e.g., via a shared include/template or generation step) so the adapter set is defined once and reused.

Copilot uses AI. Check for mistakes.
"psDscAdapter/",
"psscript.ps1",
"psscript.dsc.resource.json",
Expand All @@ -99,6 +102,7 @@
"sshd-subsystem.dsc.resource.json",
"sshd-subsystemList.dsc.resource.json",
"windowspowershell.dsc.resource.json",
"WindowsPowerShell_adapter.dsc.resource.json",
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added filenames use different casing/formatting than surrounding entries (which are largely lowercase). If the packaging/build runs on a case-sensitive filesystem (common in Linux CI or container builds), any mismatch between these strings and the actual on-disk filenames will cause file-not-found errors and missing artifacts. Recommendation: ensure these entries match the exact on-disk filenames and consider aligning naming/casing conventions with the rest of the manifest to reduce cross-platform packaging risk.

Suggested change
"WindowsPowerShell_adapter.dsc.resource.json",
"windowspowershell_adapter.dsc.resource.json",

Copilot uses AI. Check for mistakes.
"windowsupdate.dsc.resource.json",
"wu_dsc.exe",
"windows_firewall.dsc.resource.json",
Expand Down
Loading