Use reactphp/async instead of clue/reactphp-block#121
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the test suite to replace deprecated clue/reactphp-block usage with reactphp/async, and adds additional socket cleanup to avoid leaving server sockets open during/after tests.
Changes:
- Replace
Block\await()+Loop::get()with\React\Async\await()in functional test helpers. - Track and close the primary
SocketServerafter each test, and close additional per-test sockets where applicable. - Update
composer.jsondev dependencies to dropclue/block-reactand addreact/async.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/FunctionalTest.php | Migrates blocking awaits to react/async and adds explicit socket shutdowns to prevent lingering listeners. |
| composer.json | Swaps dev dependency from clue/block-react to react/async. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test suite to use reactphp/async instead of the deprecated clue/reactphp-block. See https://github.com/reactphp/async.
Builds on top of #120, clue/reactphp-block#67, clue/reactphp-block#68 and clue/reactphp-redis#149
Supersedes / closes #110 and #111 (Thank you @dinooo13 for the initial work on this!)