[google_font] Move the httpClient from a package level variable to the Config object

[bramp]

Move the httpClient from a package level variable, to be on the Config object

This allows the user to customise the httpClient as well as mock it out in tests.

Fixes #182429

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[gemini-code-assist]

Code Review

This pull request refactors the httpClient to be part of the GoogleFonts.config object. This is a good change that improves testability and allows users to provide a custom HTTP client. However, I've identified a potential resource leak issue with the default http.Client instance not being closed. My review includes a comment with details on this issue.

[gemini-code-assist]

The http.Client should be closed when it's no longer needed to release underlying resources. The current implementation creates a default client but never closes it, which can lead to resource leaks.

Please consider how the client's lifecycle will be managed. For example, you could add a static GoogleFonts.dispose() method that closes the default client. You should also document that if a user supplies their own httpClient, they are responsible for closing it.

[bramp]

Absolutely right - however before my change, this httpClient was being created globally without a way to dispose of it. So I've not made the situation worse.

I'll happily add a dispose method if folks want that - but since GoogleFonts isn't explicitly init'd I'm not sure a dispose makes sense. Because then we'd have to deal with folks trying to use GoogleFronts after it's been disposed.

[Piinks]

Thanks for the PR!

[Piinks]

Hey @bramp is this still a change you would like to work on?

[bramp]

Sorry for my slow turn around. Ok I've replied to all comments - and pushed updates for changelog/version bump. The only linger decision is in #11027 (comment)