Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s build/dev tooling for newer Webpack versions and tweaks runtime scheduling in the PCode audio execution path.
Changes:
- Upgrade Webpack/tooling dependencies and adjust Webpack config to Webpack 5
output.libraryformat. - Harden env handling in
webpack.config.jsand update the example dev-server config for newerwebpack-dev-serveroptions. - Adjust oscillator start scheduling in
lib/index.js, and add generated*.LICENSE.txtartifacts.
Reviewed changes
Copilot reviewed 4 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
webpack.config.js |
Migrates UMD library output configuration to Webpack 5 format; guards against missing env. |
package.json |
Upgrades webpack-related dev dependencies; adjusts build script and adds an overrides entry. |
lib/index.js |
Changes oscillator/noise start timing to use a relative delay when not looping. |
examples/p5-ocr/webpack.dev.js |
Updates dev-server config (static, server) and removes Workbox usage in dev. |
examples/p5-ocr/dist/main.js.LICENSE.txt |
Adds extracted license output (currently includes non-license project notes). |
dist/p-code.js.LICENSE.txt |
Adds extracted license output (currently includes non-license project notes). |
.gitignore |
Fixes ignore path to the correct example directory JS output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+202
to
206
| this.sine.start(this.looper ? this.interval : `+${1/60}`); | ||
| break; | ||
| case 'N': | ||
| this.saw.start(this.looper ? this.interval : 0); | ||
| this.saw.start(this.looper ? this.interval : `+${1/60}`); | ||
| break; |
There was a problem hiding this comment.
+${1/60} is a hard-coded, repeated scheduling offset and is embedded as a template string in multiple cases. To make the timing behavior easier to understand and adjust, consider defining a named constant (or deriving it from an existing timing setting like this.interval) and reusing it for all oscillator starts.
inafact
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
諸々バージョン上げました。
@inafact 作業中っぽいのあると思うのですが、問題なければマージしちゃいます!