Skip to content

Develop#35

Open
hysysk wants to merge 4 commits intomasterfrom
develop
Open

Develop#35
hysysk wants to merge 4 commits intomasterfrom
develop

Conversation

@hysysk
Copy link
Copy Markdown
Member

@hysysk hysysk commented Apr 15, 2026

諸々バージョン上げました。
@inafact 作業中っぽいのあると思うのですが、問題なければマージしちゃいます!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s build/dev tooling for newer Webpack versions and tweaks runtime scheduling in the PCode audio execution path.

Changes:

  • Upgrade Webpack/tooling dependencies and adjust Webpack config to Webpack 5 output.library format.
  • Harden env handling in webpack.config.js and update the example dev-server config for newer webpack-dev-server options.
  • Adjust oscillator start scheduling in lib/index.js, and add generated *.LICENSE.txt artifacts.

Reviewed changes

Copilot reviewed 4 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
webpack.config.js Migrates UMD library output configuration to Webpack 5 format; guards against missing env.
package.json Upgrades webpack-related dev dependencies; adjusts build script and adds an overrides entry.
lib/index.js Changes oscillator/noise start timing to use a relative delay when not looping.
examples/p5-ocr/webpack.dev.js Updates dev-server config (static, server) and removes Workbox usage in dev.
examples/p5-ocr/dist/main.js.LICENSE.txt Adds extracted license output (currently includes non-license project notes).
dist/p-code.js.LICENSE.txt Adds extracted license output (currently includes non-license project notes).
.gitignore Fixes ignore path to the correct example directory JS output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/index.js
Comment on lines +202 to 206
this.sine.start(this.looper ? this.interval : `+${1/60}`);
break;
case 'N':
this.saw.start(this.looper ? this.interval : 0);
this.saw.start(this.looper ? this.interval : `+${1/60}`);
break;
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+${1/60} is a hard-coded, repeated scheduling offset and is embedded as a template string in multiple cases. To make the timing behavior easier to understand and adjust, consider defining a named constant (or deriving it from an existing timing setting like this.interval) and reusing it for all oscillator starts.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants