-
Notifications
You must be signed in to change notification settings - Fork 4
Develop #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hysysk
wants to merge
4
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop #35
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ node_modules | |
| *.crt | ||
| *.key | ||
|
|
||
| example/dist/*.js | ||
| examples/p5-ocr/dist/*.js | ||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * Tone.js | ||
| * @author Yotam Mann | ||
| * @license http://opensource.org/licenses/MIT MIT License | ||
| * @copyright 2014-2019 Yotam Mann | ||
| */ | ||
|
|
||
| //! NOTE: Clamp frequency, | ||
|
|
||
| //! TODO; | ||
|
|
||
| //! because outside of [Tone.Signal<"frequency">.minValue to Tone.Signal<"frequency">.maxValue] range crash Tone.js |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /*! | ||
| * @overview es6-promise - a tiny implementation of Promises/A+. | ||
| * @copyright Copyright (c) 2014 Yehuda Katz, Tom Dale, Stefan Penner and contributors (Conversion to ES6 API by Jake Archibald) | ||
| * @license Licensed under MIT license | ||
| * See https://raw.githubusercontent.com/stefanpenner/es6-promise/master/LICENSE | ||
| * @version v4.2.8+1e68dce6 | ||
| */ | ||
|
|
||
| /*! | ||
| * The buffer module from node.js, for the browser. | ||
| * | ||
| * @author Feross Aboukhadijeh <https://feross.org> | ||
| * @license MIT | ||
| */ | ||
|
|
||
| /*! @source http://purl.eligrey.com/github/FileSaver.js/blob/master/FileSaver.js */ | ||
|
|
||
| /*! https://mths.be/codepointat v0.2.0 by @mathias */ | ||
|
|
||
| /** | ||
| * Tone.js | ||
| * @author Yotam Mann | ||
| * @license http://opensource.org/licenses/MIT MIT License | ||
| * @copyright 2014-2019 Yotam Mann | ||
| */ | ||
|
|
||
| //! NOTE: Clamp frequency, | ||
|
|
||
| //! TODO; | ||
|
|
||
| //! because outside of [Tone.Signal<"frequency">.minValue to Tone.Signal<"frequency">.maxValue] range crash Tone.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,17 @@ | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
| const WorkboxPlugin = require('workbox-webpack-plugin'); | ||
|
|
||
| module.exports = { | ||
| mode: 'development', | ||
| entry: './src/index.js', | ||
| devServer: { | ||
| contentBase: './dist', | ||
| static: './dist', | ||
| host: '0.0.0.0', | ||
| hot: true, | ||
| // https: { | ||
| // key: fs.readFileSync('./server.key'), | ||
| // cert: fs.readFileSync('./server.crt') | ||
| // } | ||
| server: 'https', | ||
| }, | ||
| output: { | ||
| filename: 'main.js', | ||
| path: path.resolve(__dirname, 'dist'), | ||
| }, | ||
| plugins: [ | ||
| new WorkboxPlugin.GenerateSW({ | ||
| clientsClaim: true, | ||
| skipWaiting: true | ||
| }) | ||
| ] | ||
| plugins: [] | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+${1/60}is a hard-coded, repeated scheduling offset and is embedded as a template string in multiple cases. To make the timing behavior easier to understand and adjust, consider defining a named constant (or deriving it from an existing timing setting likethis.interval) and reusing it for all oscillator starts.