bisect: advertise gzip,deflate encoding when supported by staabm · Pull Request #5434 · phpstan/phpstan-src

staabm · 2026-04-09T07:58:43Z

time to fetch the commits..

... before this PR

➜  phpstan-src git:(bisect-gzip) ✗ time php bin/phpstan bisect foo.php  --good=2.1.0 --bad=2.1.46

Fetching commits between 2.1.0 and 2.1.46...
--------------------------------------------

php bin/phpstan bisect foo.php --good=2.1.0 --bad=2.1.46  0.27s user 0.17s system 0% cpu 54.959 total

... after this PR

➜  phpstan-src git:(bisect-gzip) ✗ time php bin/phpstan bisect foo.php  --good=2.1.0 --bad=2.1.46

Fetching commits between 2.1.0 and 2.1.46...
--------------------------------------------

php bin/phpstan bisect foo.php --good=2.1.0 --bad=2.1.46  0.22s user 0.08s system 0% cpu 44.516 total

-> saves ~10 seconds when downloading big responses

staabm · 2026-04-09T08:14:29Z

src/Command/BisectCommand.php

 			return 1;
 		}

+		$headers = [


we might instead create a PHPStan namespaced HttpClient and re-use the gzip support in all places we currently directly use GuzzleHttp\Client

Not a namespaces child class, just a ClientFactory

Copilot

Pull request overview

This PR improves download performance for bisect (and other HTTP fetches that reuse the same client setup) by advertising gzip,deflate support to allow servers to return compressed responses when PHP can decode them.

Changes:

Added PHPStan\Internal\HttpClientFactory to create a Guzzle client and default Accept-Encoding: gzip,deflate when zlib is available.
Updated BisectCommand to create its HTTP client via the new factory.
Updated FixerApplication to create its HTTP client via the new factory (and removed the direct Client import).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`src/Internal/HttpClientFactory.php`	New factory that sets default `Accept-Encoding` and instantiates `GuzzleHttp\Client`.
`src/Command/FixerApplication.php`	Switches to using `HttpClientFactory` for download checks and removes direct client construction.
`src/Command/BisectCommand.php`	Switches to using `HttpClientFactory` for GitHub API requests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T18:02:14Z

src/Internal/HttpClientFactory.php

+	/**
+	 * @param array<mixed> $config
+	 *
+	 * @see \GuzzleHttp\RequestOptions
+	 */
+	public static function createClient(array $config): Client


PHPDoc type array<mixed> implies an int-keyed list; this config is an associative options array (RequestOptions keys). Consider changing to array<string, mixed> (or a more specific shape) so static analysis keeps key type information.

Copilot · 2026-04-09T18:02:14Z

src/Internal/HttpClientFactory.php

+		if (
+			!isset($config['headers']['Accept-Encoding'])
+			&& extension_loaded('zlib')
+		) {


isset($config['headers']['Accept-Encoding']) assumes headers is an array and only checks one exact casing. If a caller passes headers as a non-array (or uses a different header key casing), this can throw or result in duplicate Accept-Encoding values. Consider validating headers is an array and performing a case-insensitive presence check before setting the default.

Suggested change

if (

!isset($config['headers']['Accept-Encoding'])

&& extension_loaded('zlib')

) {

$hasAcceptEncodingHeader = false;

if (isset($config['headers']) && is_array($config['headers'])) {

foreach (array_keys($config['headers']) as $headerName) {

if (is_string($headerName) && strcasecmp($headerName, 'Accept-Encoding') === 0) {

$hasAcceptEncodingHeader = true;

break;

}

}

}

if (

!$hasAcceptEncodingHeader

&& extension_loaded('zlib')

) {

if (!isset($config['headers']) || !is_array($config['headers'])) {

$config['headers'] = [];

}

Copilot · 2026-04-09T18:02:14Z

src/Internal/HttpClientFactory.php

+	{
+		if (
+			!isset($config['headers']['Accept-Encoding'])
+			&& extension_loaded('zlib')


This factory forces Accept-Encoding whenever zlib is available, even if the caller explicitly disables decompression via RequestOptions::DECODE_CONTENT => false. In that case the response may be compressed but not decoded. Consider only advertising gzip/deflate when decode_content is not set to false (or when it’s true).

Suggested change

&& extension_loaded('zlib')

&& extension_loaded('zlib')

&& (

!\array_key_exists(\GuzzleHttp\RequestOptions::DECODE_CONTENT, $config)

|| $config[\GuzzleHttp\RequestOptions::DECODE_CONTENT] !== false

)

ondrejmirtes · 2026-04-09T20:25:55Z

src/Internal/HttpClientFactory.php

+	 *
+	 * @see \GuzzleHttp\RequestOptions
+	 */
+	public static function createClient(array $config): Client


Should be a service, not a static function. So we can pass options from config parameters

staabm added 3 commits April 9, 2026 09:53

bisect: advertise gzip,deflate encoding when supported

8133e71

Update BisectCommand.php

ff7fe8d

cs

810a43b

staabm requested a review from ondrejmirtes April 9, 2026 08:05

staabm commented Apr 9, 2026

View reviewed changes

staabm added 4 commits April 9, 2026 10:26

HttpClientFactory

60457f0

Update FixerApplication.php

7c4b805

fix

97e5b10

Update FixerApplication.php

dcc038f

staabm requested review from VincentLanglet and Copilot April 9, 2026 17:58

Copilot started reviewing on behalf of staabm April 9, 2026 17:58 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

VincentLanglet approved these changes Apr 9, 2026

View reviewed changes

ondrejmirtes requested changes Apr 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bisect: advertise gzip,deflate encoding when supported#5434

bisect: advertise gzip,deflate encoding when supported#5434
staabm wants to merge 7 commits intophpstan:2.1.xfrom
staabm:bisect-gzip

staabm commented Apr 9, 2026 •

edited

Loading

Uh oh!

staabm Apr 9, 2026

Uh oh!

ondrejmirtes Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

ondrejmirtes Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-		if (
-			!isset($config['headers']['Accept-Encoding'])
-			&& extension_loaded('zlib')
-		) {
+		$hasAcceptEncodingHeader = false;
+		if (isset($config['headers']) && is_array($config['headers'])) {
+			foreach (array_keys($config['headers']) as $headerName) {
+				if (is_string($headerName) && strcasecmp($headerName, 'Accept-Encoding') === 0) {
+					$hasAcceptEncodingHeader = true;
+					break;
+				}
+			}
+		}
+		if (
+			!$hasAcceptEncodingHeader
+			&& extension_loaded('zlib')
+		) {
+			if (!isset($config['headers']) || !is_array($config['headers'])) {
+				$config['headers'] = [];
+			}

Conversation

staabm commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staabm Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

ondrejmirtes Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

ondrejmirtes Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

staabm commented Apr 9, 2026 •

edited

Loading