-
Notifications
You must be signed in to change notification settings - Fork 568
bisect: advertise gzip,deflate encoding when supported #5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
staabm
wants to merge
9
commits into
phpstan:2.1.x
Choose a base branch
from
staabm:bisect-gzip
base: 2.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−8
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
42ecacf
bisect: advertise gzip,deflate encoding when supported
staabm 1217816
Update BisectCommand.php
staabm c9e08aa
cs
staabm 54a0b90
HttpClientFactory
staabm 0b9d21d
Update FixerApplication.php
staabm 7907e12
fix
staabm 4813a6a
Update FixerApplication.php
staabm f60d353
made HttpClientFactory a service
staabm dac22f8
centralize timeout
staabm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace PHPStan\Internal; | ||
|
|
||
| use GuzzleHttp\Client; | ||
| use GuzzleHttp\RequestOptions; | ||
| use PHPStan\DependencyInjection\AutowiredService; | ||
| use function extension_loaded; | ||
|
|
||
| #[AutowiredService] | ||
| final class HttpClientFactory | ||
| { | ||
|
|
||
| public function __construct( | ||
| private int $timeout = 30, | ||
| private int $connectTimeout = 10, | ||
| ) | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * @param array<mixed> $config | ||
| * | ||
| * @see \GuzzleHttp\RequestOptions | ||
| */ | ||
| public function createClient(array $config): Client | ||
| { | ||
| if ( | ||
| !isset($config['headers']['Accept-Encoding']) | ||
| && extension_loaded('zlib') | ||
staabm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ) { | ||
staabm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| $config['headers']['Accept-Encoding'] = 'gzip,deflate'; | ||
| } | ||
|
|
||
| $defaults = [ | ||
| RequestOptions::TIMEOUT => $this->timeout, | ||
| RequestOptions::CONNECT_TIMEOUT => $this->connectTimeout, | ||
| ]; | ||
|
|
||
| return new Client($config + $defaults); | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make use of this service via DI in this command we would need to call
CommandHelpe::begin, and this might require more changes.I feel its not the right time todo this now. as this command is using cli options to pass it into a subshell, which
CommandHelpe::beginseems to expect to be used for the main-process